feat: don't rebuild container on bazel version change#9073
Open
feat: don't rebuild container on bazel version change#9073
Conversation
Contributor
|
Run URL: https://github.com/dfinity/ic/actions/runs/22483223367 New container image: |
c0432d5 to
d9c1887
Compare
This removes the `.bazelversion` as a dependency from the `Dockerfile`, meaning that bazel version bumps won't force the container to be rebuilt. The `.bazelversion` was only used to generate bash completion. The bash completion is now run only in interactive mode (if no command is run) and as the container is run (not built). (bazelisk is bumped to a recent version that contains the completion command)
efbeaf9 to
6b953aa
Compare
…a41b575d7d9045930ec97494afbce7 Image tag: d6be76135e33664d3232e5476a6707d7c3bf9fc9fa5407b3496a444d2e16a7f8
mbjorkqvist
approved these changes
Feb 27, 2026
basvandijk
approved these changes
Feb 27, 2026
venkkatesh-sekar
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the
.bazelversionas a dependency from theDockerfile, meaning that bazel version bumps won't force the container to be rebuilt.The
.bazelversionwas only used to generate bash completion. The bash completion is now run only in interactive mode (if no command is run) and as the container is run (not built).(bazelisk is bumped to a recent version that contains the
completioncommand)